[PATCH] D46690: [ELF] - Improve the test cases for notes sections.

[Ed Maste via Phabricator via llvm-commits]

emaste accepted this revision.
emaste added a comment.

In https://reviews.llvm.org/D46690#1094394, @grimar wrote:

> After the second look, I think it is ok to add check here that we still keep non-a section and keep its SHT_NOTE flag for safety though. I'll update the patch.


Yes, a safety check that we don't accidentally break this in the future was my main concern. As @ruiu said in the other review it seems the ghc folks are using the non-alloc note effectively as a `.comment` section and I'd like to confirm we maintain that functionality.



================
Comment at: test/ELF/note-noalloc.s:17
 
-// CHECK: Type: PT_NOTE
-// CHECK-NOT: Type: PT_NOTE
+// Check we still emit the non-alloc SHT_NOTE section and keep it's type.
 
----------------
its


https://reviews.llvm.org/D46690