[PATCH] D46668: [STLExtras] Add a range-based distance()

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

I sort of wonder if we should have a pred_size and succ_size helper.



================
Comment at: lib/AsmParser/LLParser.cpp:6760
     return Error(Loc, "wrong number of indexes, expected " +
-                          Twine(std::distance(V->use_begin(), V->use_end())));
+                          Twine(distance(V->uses())));
 
----------------
Should this just be V->getNumUses()?


================
Comment at: lib/Bitcode/Writer/ValueEnumerator.cpp:492
 
-    OS << " Uses(" << std::distance(V->use_begin(),V->use_end()) << "):";
+    OS << " Uses(" << distance(V->uses()) << "):";
     for (const Use &U : V->uses()) {
----------------
V->getNumUses()?


================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:1814
     // PERF: trade a linear scan for repeated reallocation
-    Uses.reserve(std::distance(Def->user_begin(), Def->user_end()));
+    Uses.reserve(distance(Def->users()));
     for (User *U : Def->users()) {
----------------
Def->getNumUses()


https://reviews.llvm.org/D46668