[PATCH] D46517: [sanitizer] Don't miss threads by ThreadSuspender

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:935
+        // If proc_task_readdir returned because buffer was not enough and it
+        // stopped on thread which is termination it may not recover position.
+        // In this case we lose the rest and may be unable to recognize this as
----------------
s/termination/terminated


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:942
+      if (i > 1) {
+        // With probably should not get here with check about.
+        // We can have short read because of small buffer (handled above),
----------------
I can't parse this comment.
s/with/we, s/about/above ?


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc:222
+      case ThreadLister::Incomplete:
+        added_threads = true;
+        break;
----------------
Maybe rename to smth like "bool retry" ? Otherwise it is not clear why an incomplete list results in added_threads = true.


Repository:
  rL LLVM

https://reviews.llvm.org/D46517