[PATCH] D46648: [SimplifyLibcalls] Optimize string concats using s(n)printf

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 9 13:40:39 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D46648#1093505, @efriedma wrote:

> If your results appear to be "correct", you're just getting lucky that your particular combination of compiler and C library don't do something else.
>
> We should probably just add clang -Wformat warning, rather than try to optimize it in SimplifyLibCalls.


And ubsan, if it does not handle this already.


Repository:
  rL LLVM

https://reviews.llvm.org/D46648





More information about the llvm-commits mailing list