[PATCH] D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Seems good - thanks for your patience.



================
Comment at: unittests/DebugInfo/DWARF/DwarfGenerator.cpp:472-474
+  for (auto &LT : LineTables) {
+    LT->generate(*MC, *Asm);
+  }
----------------
Usually LLVM code omits braces from single line blocks.


================
Comment at: unittests/DebugInfo/DWARF/DwarfGenerator.cpp:501-502
+dwarfgen::LineTable &dwarfgen::Generator::addLineTable(DwarfFormat Format) {
+  LineTables.push_back(std::unique_ptr<LineTable>(
+      new LineTable(*this, Version, Format, Asm->getPointerSize())));
+  return *LineTables.back();
----------------
make_unique?


Repository:
  rL LLVM

https://reviews.llvm.org/D44560