[PATCH] D44623: Fix asan on i?86-linux (32-bit) against glibc 2.27 and later

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cc:174
+
+#if CHECK_GET_TLS_STATIC_INFO_VERSION
 # define DL_INTERNAL_FUNCTION __attribute__((regparm(3), stdcall))
----------------
Do we need this if we do runtime check anyway?
We can't get into GetTlsStaticInfoRegparmCall with CHECK_GET_TLS_STATIC_INFO_VERSION == 0


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cc:238
   uptr len = confstr(_CS_GNU_LIBC_VERSION, buf, sizeof(buf));
   if (len < sizeof(buf) && internal_strncmp(buf, "glibc 2.", 8) == 0) {
     char *end;
----------------
Is this the same as __GLIBC_PREREQ()


Repository:
  rL LLVM

https://reviews.llvm.org/D44623