[PATCH] D44623: Fix asan on i?86-linux (32-bit) against glibc 2.27 and later

[Peter Wu via Phabricator via llvm-commits]

Lekensteyn added a comment.

Other than the inline lint warnings, it looks good to me. (The patch is also missing the directory, but it applies otherwise.)

I tried this and the `check-sanitizer` tests pass with glibc 2.27. A simple 32-bit test program also passes both glibc 2.27 and 2.26.



================
Comment at: sanitizer_linux_libcdep.cc:196
+}
+}
+
----------------
Lint complains here:

    sanitizer_linux_libcdep.cc:196:  Namespace should be terminated with "// namespace"  [readability/namespace] [5]



================
Comment at: sanitizer_linux_libcdep.cc:210
+    CallGetTls<GetTlsStaticInfoRegparmCall>(get_tls_static_info_ptr,
+					    &tls_size, &tls_align);
+  else
----------------
More lint complaints:

    sanitizer_linux_libcdep.cc:210:  Tab found; better to use spaces  [whitespace/tab] [1]
    sanitizer_linux_libcdep.cc:213:  Tab found; better to use spaces  [whitespace/tab] [1]



Repository:
  rL LLVM

https://reviews.llvm.org/D44623