[PATCH] D46636: [llvm-rc] Add support for the RCDATA resource type

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

The docs suggest there are differences between RCDATA and user-defined resource definitions, but the Microsoft rc.exe doesn't seem to follow the docs.  For example, the docs say user-defined types can use an external file but that RCDATA cannot. In real life, the resource compiler will accept an RCDATA statement that does reference an external file.  Also, the docs say RCDATA can have VERSION, CHARACTERISTICS, and LANGUAGE optional statements, but those don't seem to work because the keywords are mistaken for file names.

This change seems to match the behavior rather than the docs in these regards.  I think that's the right way to go.


Repository:
  rL LLVM

https://reviews.llvm.org/D46636