[PATCH] D46595: [InstCombine] Apply SimplifyUsingDistributiveLaws to associative/commutative cases.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: test/Transforms/InstCombine/bit-check-combine.ll:3
+; RUN: opt < %s -instcombine -S | FileCheck %s
+; RUN: opt < %s -instcombine -gvn -instcombine -S | FileCheck %s --check-prefix=COMPLEX
+
----------------
The general direction is still under discussion, but I want to point out some test changes that would make this easier to understand:

1. Unless there's some exceptional circumstance, we shouldn't have regression tests for anything but instcombine here. If you want to check more than that, you might add something under tests/PhaseOrdering.

2. I'm having a hard time seeing the motivating patterns for these tests. The 2nd and 3rd tests are already canonicalized by instcombine to the asserted forms shown in the CHECK lines? The 1st test gets reduced significantly. The 4th test should not require 8 params, loads, etc.


Repository:
  rL LLVM

https://reviews.llvm.org/D46595