[PATCH] D46620: Fix side effect in debug code

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 9 06:52:52 PDT 2018


kparzysz added a comment.

The whole loop is an assert.  The only purpose of it is to verify the ID vs. its position in the loop.  Maybe having `for (unsigned i = ...; i != e; ++i)` instead would be cleaner, but I think it's ok as is.  I don't have a problem with changing it either, but I wouldn't say it's necessary.


Repository:
  rL LLVM

https://reviews.llvm.org/D46620





More information about the llvm-commits mailing list