[PATCH] D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes

[whitequark via Phabricator via llvm-commits]

whitequark requested changes to this revision.
whitequark added inline comments.
This revision now requires changes to proceed.


================
Comment at: include/llvm-c/DebugInfo.h:851
+ */
+void LLVMDeleteTemporaryMDNode(LLVMMetadataRef TempNode);
+
----------------
I think this should be called `LLVMDisposeTemporaryMDNode`, by analogy with every other destructor.


================
Comment at: include/llvm-c/DebugInfo.h:858
+ */
+void LLVMMetadataReplaceAllUsesWith(LLVMMetadataRef TempTargetMetadata,
+                                    LLVMMetadataRef Replacement);
----------------
Is this really necessary? If this function remains, it should at least be documented that it is exactly the same as calling `LLVMReplaceAllUsesWith` and then `LLVMDisposeTemporaryMDNode`, but I'm not convinced that it has much value.


Repository:
  rL LLVM

https://reviews.llvm.org/D46632