[PATCH] D46527: Object: Find terminator correctly when getting long filenames from GNU archives
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 9 01:25:49 PDT 2018
hans added a comment.
Thanks, Peter! I've committed a test based on this in r331854.
Bob: Sorry, I should have made the commit message a bit clearer. It mentioned looking for a null-byte, but it's not obvious that it's the StringRef constructor that was doing it, due to calling strlen. Lack of null-terminator is a classic bug when constructing StringRefs.
Repository:
rL LLVM
https://reviews.llvm.org/D46527
More information about the llvm-commits
mailing list