[PATCH] D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 8 21:47:57 PDT 2018


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/Analysis/IVUsers/deep_recursion_in_scev.ll:9
+bb:
+  %tmp = load volatile i32, i32 addrspace(256)* inttoptr (i64 104 to i32 addrspace(256)*), align 8
+  %tmp2 = getelementptr inbounds i8, i8 addrspace(1)* %arg, i64 80
----------------
Minor nit:  this test can probably be cleaned up a bit.  For instance, instead of the volatile load you can pass in `%tmp` as a parameter, and you can remove the addressspace qualifiers.


https://reviews.llvm.org/D46046





More information about the llvm-commits mailing list