[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 8 21:20:50 PDT 2018
mstorsjo added a comment.
In https://reviews.llvm.org/D46520#1092233, @rnk wrote:
> Please don't do this, this is actually really problematic, since `#line` directives lose information about what's a system header. That means the result of -E usually won't compile, since Windows headers are typically full of warnings and default-error warnings.
Oh, ok - I can revert it then; I didn't have any specific need for this, I just noticed that clang in msvc mode and cl.exe differed in this aspect.
Repository:
rL LLVM
https://reviews.llvm.org/D46520
More information about the llvm-commits
mailing list