[PATCH] D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS

Walter Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 8 20:05:38 PDT 2018


waltl marked 3 inline comments as done.
waltl added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:15
 
+#include <string.h>
 #include "asan_interceptors_memintrinsics.h"
----------------
lebedev.ri wrote:
> kcc wrote:
> > krytarowski wrote:
> > > rationale?
> > please don't. 
> > this file should not include any system headers. 
> Was passing of `-nostdinc` / `-nostdlib` / `-nostdlibinc` / `-nostdinc++` / `-nostdlib++` compiler options when building compiler-rt / xray been considered?
> I wonder if that would help enforce these rules.
I reverted it.  Will propose something else in a separate patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D46454





More information about the llvm-commits mailing list