[PATCH] D46223: Introduce a direct LLVM IR execution UnitTests framework, and add the first such test.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 8 18:20:30 PDT 2018


rnk added a comment.

I think the overall idea is great!

In https://reviews.llvm.org/D46223#1085479, @dblaikie wrote:

> Keeping these tests as checked in bitcode is to ensure less churn as the IR changes since these tests are likely to be relatively static? Given all the IR in test cases we generally have to upgrade/modify when changing the format - is it much of a savings to have these in bitcode?


I think we might as well compile the .ll file instead of the .bc file instead of checking in the .bc. The IR printed from llvm-dis changes style frequently, but most boring .ll inputs have stayed valid over a long period of time.


Repository:
  rT test-suite

https://reviews.llvm.org/D46223





More information about the llvm-commits mailing list