[llvm] r331827 - [CMake] Use CMAKE_OBJCOPY and CMAKE_STRIP to externalize debug info
Petr Hosek via llvm-commits
llvm-commits at lists.llvm.org
Tue May 8 17:07:43 PDT 2018
Author: phosek
Date: Tue May 8 17:07:42 2018
New Revision: 331827
URL: http://llvm.org/viewvc/llvm-project?rev=331827&view=rev
Log:
[CMake] Use CMAKE_OBJCOPY and CMAKE_STRIP to externalize debug info
Don't hardcode objcopy and strip names, rather use CMAKE_OBJCOPY and
CMAKE_STRIP variables which allows users to override the tools used
such as using llvm-objcopy and llvm-strip instead of binutils versions.
Differential Revision: https://reviews.llvm.org/D46611
Modified:
llvm/trunk/cmake/modules/AddLLVM.cmake
Modified: llvm/trunk/cmake/modules/AddLLVM.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=331827&r1=331826&r2=331827&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/AddLLVM.cmake (original)
+++ llvm/trunk/cmake/modules/AddLLVM.cmake Tue May 8 17:07:42 2018
@@ -1546,7 +1546,7 @@ function(llvm_externalize_debuginfo name
if(APPLE)
set(strip_command COMMAND xcrun strip -Sxl $<TARGET_FILE:${name}>)
else()
- set(strip_command COMMAND strip -gx $<TARGET_FILE:${name}>)
+ set(strip_command COMMAND ${CMAKE_STRIP} -gx $<TARGET_FILE:${name}>)
endif()
endif()
@@ -1564,9 +1564,9 @@ function(llvm_externalize_debuginfo name
)
else()
add_custom_command(TARGET ${name} POST_BUILD
- COMMAND objcopy --only-keep-debug $<TARGET_FILE:${name}> $<TARGET_FILE:${name}>.debug
+ COMMAND ${CMAKE_OBJCOPY} --only-keep-debug $<TARGET_FILE:${name}> $<TARGET_FILE:${name}>.debug
${strip_command} -R .gnu_debuglink
- COMMAND objcopy --add-gnu-debuglink=$<TARGET_FILE:${name}>.debug $<TARGET_FILE:${name}>
+ COMMAND ${CMAKE_OBJCOPY} --add-gnu-debuglink=$<TARGET_FILE:${name}>.debug $<TARGET_FILE:${name}>
)
endif()
endfunction()
More information about the llvm-commits
mailing list