[PATCH] D45736: [SimplifyLibcalls] Replace locked IO with unlocked IO

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The code looks fine.  But I'm a bit worried this could break in some cases.  It's possible a user could define a function named fputc_unlocked, so we wouldn't accept a valid C program.  And it's possible this could break some runtime instrumentation tools which haven't implemented the *_unlocked functions.  Or someone could use some obscure C library on Linux which doesn't have all the glibc extensions and get surprised by a link error.

So I'm not sure what to do here; maybe get a second opinion on llvmdev?


https://reviews.llvm.org/D45736