[PATCH] D46579: [llvm-rc] Handle C preprocessor output

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added inline comments.


================
Comment at: tools/llvm-rc/ResourceScriptCppFilter.cpp:106
+  StringRef Ext = Path.substr(ExtPos + 1);
+  if (Ext.equals_lower("h")) {
+    Outputting = false;
----------------
also "c"


================
Comment at: tools/llvm-rc/ResourceScriptCppFilter.h:16
+// headers can leave behind C declarations, that RC doesn't understand.
+// Rc.exe simply discards anything that comes from files named *.h.
+//
----------------
Also from files name *.c.  See last paragraph on:

https://msdn.microsoft.com/en-us/library/windows/desktop/aa381033(v=vs.85).aspx

This is a hack from the old days.  Instead of putting your UI IDs into a header, you'd just define them in the .c file that implements that part of the UI, knowing that the .c file could be included in the resource script.


Repository:
  rL LLVM

https://reviews.llvm.org/D46579