[PATCH] D44623: Fix asan on i?86-linux (32-bit) against glibc 2.27 and later

[Peter Wu via Phabricator via llvm-commits]

Lekensteyn added a comment.

> Is a test possible? Or is this covered by an existing test? Which one?

When unpatched, all 781 i386 tests fail with glibc 2.27. I think that should be good enough :-)

> Is this related to https://github.com/google/sanitizers/issues/914 or this is another problem?

Could be related, but it can be fixed independently as it is just a different calling convention. See https://github.com/google/sanitizers/issues/954

As mentioned in the comments in that bug, would it be worth factoring out the confstr minor/patch version check from ThreadDescriptorSize and reusing that function here instead of calling dlvsym? Glibc 2.27 is currently released as stable, so pre-2.27 versions after 2.26 should be nearly non-existent right?


Repository:
  rL LLVM

https://reviews.llvm.org/D44623