[PATCH] D46579: [llvm-rc] Handle C preprocessor output

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: tools/llvm-rc/ResourceScriptCppFilter.cpp:54
+    if (parseLine(Line))
+      Result += FullLine;
+  }
----------------
This is O(n^2). This shouldn't need any copies until it's time to join the string, so you can make a `std::vector<StringRef>` and then use `return llvm::join(Lines, "")`, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D46579