[PATCH] D46512: [ARM] Add support for SETCCCARRY instead of SETCCE

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with minor comments.



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:1068
   // Thumb-1 cannot currently select ARMISD::SUBE.
   if (!Subtarget->isThumb1Only())
+    setOperationAction(ISD::SETCCCARRY, MVT::i32, Custom);
----------------
Do we still need the Thumb1Only check here?  I thought we fixed that.  But I guess we can change that as a followup.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:10342
   SelectionDAG &DAG(DCI.DAG);
-
   if (N->getOpcode() == ARMISD::SUBC) {
----------------
Whitespace change?


Repository:
  rL LLVM

https://reviews.llvm.org/D46512