[PATCH] D46507: [llvm-rc] Add support for all missing dialog controls

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 8 11:12:03 PDT 2018


mstorsjo added inline comments.


================
Comment at: tools/llvm-rc/ResourceScriptStmt.cpp:146
+    {"SCROLLBAR", CtlInfo{0x50000000, ClsScrollBar, false}},
+    {"CONTROL", CtlInfo{0x5000002A, 0, true}},
 };
----------------
amccarth wrote:
> For `CONTROL`, where does the `0x2A` come from?  I know `0x5000000` is `WS_CHILD | WS_VISIBLE`.
> 
> It would be nice to see the styles represented in a way that makes it easier to check the table.
Oh, that 0x2A must be from the test file itself. Will fix.


https://reviews.llvm.org/D46507





More information about the llvm-commits mailing list