[PATCH] D45842: [Reassociate] swap binop operands to increase factoring potential

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 8 09:54:30 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D45842#1091129, @lebedev.ri wrote:

> One important take-away from https://reviews.llvm.org/D46336#1090588:
>  The InstCombine and Reassociate need to be run after each another in a loop (what't the correct term, internal pipeline?) until neither of them produces any more changes.
>
>   bool madeChanges = false;
>   do {
>     madeChanges |= instcombine();
>     madeChanges |= reassociate();
>   } while(madeChanges);
>


There are parallel conversations going on about the general direction, so let's move this to llvm-dev and reach consensus before we get into the details:
http://lists.llvm.org/pipermail/llvm-dev/2018-May/123117.html


https://reviews.llvm.org/D45842





More information about the llvm-commits mailing list