[PATCH] D46478: [Coverage] Do not skip functions with the same name when loading CoverageMapping.
Max Moroz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 8 08:57:06 PDT 2018
Dor1s added a comment.
In https://reviews.llvm.org/D46478#1090589, @vsk wrote:
> ...
> Maybe you could change the FunctionNames StringSet to some kind of filename-based map.
Thanks Vedant, that's a great idea! I haven't realized that `FunctionNames` isn't used for anything else.
I've updated the change + sophisticated tests a little bit, everything seems to work fine:
$ ninja check-llvm check-clang check-lld check-polly
[139/151] Running polly regression tests
Testing Time: 7.20s
Expected Passes : 1018
Expected Failures : 24
Unsupported Tests : 95
[140/151] Running lld test suite
Testing Time: 2.61s
Expected Passes : 1309
Unsupported Tests : 330
[143/151] Running the LLVM regression tests
Testing Time: 27.77s
Expected Passes : 14856
Expected Failures : 49
Unsupported Tests : 10501
[150/151] Running the Clang regression tests
llvm-lit: ~/Projects/llvm/llvm/utils/lit/lit/llvm/config.py:334: note: using clang: ~/Projects/llvm/build/bin/clang
Testing Time: 33.98s
Expected Passes : 11999
Expected Failures : 18
Unsupported Tests : 283
Repository:
rL LLVM
https://reviews.llvm.org/D46478
More information about the llvm-commits
mailing list