[PATCH] D46527: Object: Find terminator correctly when getting long filenames from GNU archives

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In https://reviews.llvm.org/D46527#1089776, @ruiu wrote:

> Maybe you can test this by checking in a binary file?


I made an input file exactly 4096 bytes long and without any null bytes after the string, but I was not able to make it reliably crash :-(

In https://reviews.llvm.org/D46527#1089820, @smeenai wrote:

> Is this fixing the same issue as https://reviews.llvm.org/D46214?


Yes, looks like exactly the same thing. I hadn't seen that one, and it seems my patch has more velocity now.

In https://reviews.llvm.org/D46527#1091014, @inglorion wrote:

> Accepted so that you can land the fix if still needed, per my comment at https://bugs.chromium.org/p/chromium/issues/detail?id=840260#c9


Thanks! Yes, it's still needed. Our buildbot is as red as ever.

It's not ideal not having a test for this, but I still believe it's strictly an improvement so I'll go ahead and commit.


https://reviews.llvm.org/D46527