[PATCH] D46407: [tools] Introduce llvm-strip

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

As I had open comments, I'd have preferred this not been committed until after I'd given the thumbs up too...

Test comments are all that I've got though.



================
Comment at: llvm/trunk/test/tools/llvm-objcopy/strip-debug.test:13
+
+# RUN: not llvm-strip -strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
+
----------------
This should probably be a distinct test that doesn't use any command-line options (similar to the basic-copy style tests for objcopy).


================
Comment at: llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp:494
+  for (auto Arg : InputArgs.filtered(STRIP_UNKNOWN))
+    error("unknown argument '" + Arg->getAsString(InputArgs) + "'");
+  for (auto Arg : InputArgs.filtered(STRIP_INPUT))
----------------
Test case for this as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D46407