[PATCH] D46564: [SSAUpdaterBulk] Sort blocks in IDF to avoid non-determinism.

[Michael Zolotukhin via Phabricator via llvm-commits]

mzolotukhin added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:361-364
+  unsigned NextBBNum = 0;
+  for (auto &BB : F)
+    BBNumbers[&BB] = NextBBNum++;
+
----------------
davide wrote:
> mzolotukhin wrote:
> > davide wrote:
> > > Do you need to number also unreachable blocks? You could skip them, I think.
> > That's true, they shouldn't be in IDF.
> To be more clear (sorry if I wasn't), few lines later you already have a walk of the blocks in function order, so you can piggy back on that to value number non-unreachable blocks (as you're querying the dominator for reachability anyway.
No, I got this:) I will change that before committing.


Repository:
  rL LLVM

https://reviews.llvm.org/D46564