[PATCH] D46400: Add support for thinlto option to emit import files for thinlink

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/LTO.cpp:173
+
+    if (Config->ThinLTOEmitImportsFiles) {
+      openFile(OutputFileName + ".imports");
----------------
nit: remove {}


================
Comment at: lld/ELF/LTO.cpp:277
+      
+      std::string OutputFileName = getThinLTOOutputFile(F->getName());
       std::unique_ptr<raw_fd_ostream> OS =
----------------
OutputFileName seems a bit inaccurate as a variable name because it is not an output file name but a prefix. I'd just name `Path`.


================
Comment at: lld/ELF/LTO.cpp:287
+
+      if (Config->ThinLTOEmitImportsFiles) {
+        openFile(OutputFileName + ".imports");
----------------
remove {}


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46400