[PATCH] D46478: [Coverage] Do not skip functions with the same name when loading CoverageMapping.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D46478#1090585, @Dor1s wrote:

> In https://reviews.llvm.org/D46478#1090568, @vsk wrote:
>
> > In https://reviews.llvm.org/D46478#1090502, @Dor1s wrote:
> >
> > >   LLVM-Unit :: ProfileData/./ProfileDataTests/ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0
> >
> >
> > This test was added in r284251 along with the initial support for loading coverage data from multiple object files. The basic idea behind seems reasonable, as it makes sense to skip records which are exact duplicates. Do you think the duplicate detection could be enhanced by taking filenames and function hashes into account?
> >
> > - Ah, I see your update to the unit test. Yes, I think a version of loadFunctionRecord which satisfies this test would be great.
>
>
> Thanks for taking a look. I hope so, but can't figure out a proper way to implement that. Continue looking into that.


Maybe you could change the FunctionNames StringSet to some kind of filename-based map.


Repository:
  rL LLVM

https://reviews.llvm.org/D46478