[PATCH] D46526: [NewPM] Emit inliner NoDefinition missed optimization remark

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: test/Other/new-pm-defaults.ll:117
 ; CHECK-O-NEXT: Running analysis: FunctionAnalysisManagerCGSCCProxy
+; CHECK-O-NEXT: Running pass: PostOrderFunctionAttrsPass
 ; CHECK-O3-NEXT: Running pass: ArgumentPromotionPass
----------------
eraman wrote:
> It is not obvious to me why they get swapped. 
Due to the first change in Inliner.cpp - we now need to get the FunctionAnalysisManagerCGSCCProxy earlier than before. It is also accessed later for a different remark, and we don't need to re-run the analysis at that point since we have already done it.


Repository:
  rL LLVM

https://reviews.llvm.org/D46526