[PATCH] D46408: [sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC)
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 7 11:48:13 PDT 2018
vitalybuka added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_allocator_bytemap.h:21
public:
- void TestOnlyInit() {
+ void Init() {
internal_memset(map_, 0, sizeof(map_));
----------------
cryptoad wrote:
> vitalybuka wrote:
> > I'd call it Reset().
> I feel like Reset could be confusing as it could lead someone to think it can be called for more purposes than initialization.
Up to you, but I see no issues if it called for more purposes.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D46408
More information about the llvm-commits
mailing list