[PATCH] D46509: [llvm-rc] Implement the BITMAP resource type

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: tools/llvm-rc/ResourceFileWriter.cpp:705
+  // Skip the 14 byte BITMAPFILEHEADER.
+  if (Buffer.size() < 14 || Buffer[0] != 'B' || Buffer[1] != 'M')
+    return createError("Incorrect bitmap file.");
----------------
zturner wrote:
> Can you add a line above this `constexpr size_t BITMAPFILEHEADER_size = 14;` and then use this here and below?
Sure, will do.


Repository:
  rL LLVM

https://reviews.llvm.org/D46509