[PATCH] D46511: [llvm-rc] Don't strictly require quotes around external file names

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added inline comments.


================
Comment at: test/tools/llvm-rc/Inputs/include.rc:3
+// Test including filenames without quotes.
+foo BITMAP bitmap.bmp
----------------
mstorsjo wrote:
> zturner wrote:
> > Shouldn't we test both things?
> I would have guessed that there are other tests that successfully include files, but otoh the icon/cursor test is still missing its inputs. I'll update this to make it test both.
And perhaps some of the more interesting resource types, like RCDATA, that can take either a filename or a block of raw data.


================
Comment at: tools/llvm-rc/ResourceScriptToken.cpp:290
   const char CurChar = Data[Pos];
-  return std::isalnum(CurChar) || CurChar == '_';
+  return std::isalnum(CurChar) || CurChar == '_' || CurChar == '.' || CurChar == '/';
 }
----------------
What about backslashes?

```
101 BITMAP "assets\foo.bmp"
```




Repository:
  rL LLVM

https://reviews.llvm.org/D46511