[PATCH] D46508: [llvm-rc] Allow optional commas between the string table index and value

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: test/tools/llvm-rc/Inputs/tag-stringtable-basic.rc:9
+  1, "b"
+  16, "bb"
 }
----------------
zturner wrote:
> Can you put a comment above this that says "commas are optional, so we make sure to test both cases"?
> 
> This way someone editing this test in the future knows to preserve the commas.
> 
> Alternatively, you could break this out into a separate test called `tag-stringtable-commas.rc`
Sure, I'll add a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D46508