[PATCH] D46511: [llvm-rc] Don't strictly require quotes around external file names
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 7 09:49:03 PDT 2018
zturner added inline comments.
================
Comment at: test/tools/llvm-rc/Inputs/include.rc:3
+// Test including filenames without quotes.
+foo BITMAP bitmap.bmp
----------------
Shouldn't we test both things?
================
Comment at: tools/llvm-rc/ResourceScriptParser.h:87
Expected<StringRef> readIdentifier(); // Parse an identifier.
+ Expected<StringRef> readFilename(); // Parse a filename.
Expected<IntOrString> readIntOrString(); // Parse an integer or a string.
----------------
Is it really on the case that MSVC rc special cases this for filenames and not other types of strings?
Repository:
rL LLVM
https://reviews.llvm.org/D46511
More information about the llvm-commits
mailing list