[PATCH] D46192: Script to match open Phabricator reviews with potential reviewers

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 7 07:50:03 PDT 2018


kristof.beyls marked 2 inline comments as done.
kristof.beyls added inline comments.


================
Comment at: utils/Reviewing/find_interesting_reviews.py:1
+from phabricator import Phabricator
+import pickle
----------------
lebedev.ri wrote:
> lebedev.ri wrote:
> > Can `#!/usr/bin/env python` be prepended as the first line?
> Also, the standard licensing blurb at the top is missing.
Added in latest updated patch.


================
Comment at: utils/Reviewing/find_interesting_reviews.py:1
+from phabricator import Phabricator
+import pickle
----------------
kristof.beyls wrote:
> lebedev.ri wrote:
> > lebedev.ri wrote:
> > > Can `#!/usr/bin/env python` be prepended as the first line?
> > Also, the standard licensing blurb at the top is missing.
> Added in latest updated patch.
I tried to find an example in any of the other python scripts under util, but I couldn't see any licensing blurbs in any of the existing python files.
Maybe best not to invent a licensing blurb in Python syntax here and just leave it as is?


https://reviews.llvm.org/D46192





More information about the llvm-commits mailing list