[PATCH] D46511: [llvm-rc] Don't strictly require quotes around external file names

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: zturner, amccarth, mnbvmar.

Regardless of what docs may say, existing resource files in the wild can use this syntax.

I know it isn't too nice to extend the concept of what can be tokenized as an identifier like this (extending it to anything that could be a pathname, like `../foo/bar`), but on the other hand, I'd like this to be able to parse existing .rc files that all other rc tools (rc.exe, windres and wrc) can handle just fine. I ran into this issue with https://source.winehq.org/git/wine.git/blob/540c48b91175b11c7b8646d0a036b20c46425080:/programs/winemine/winemine.rc#l109.


Repository:
  rL LLVM

https://reviews.llvm.org/D46511

Files:
  test/tools/llvm-rc/Inputs/include.rc
  test/tools/llvm-rc/parser.test
  tools/llvm-rc/ResourceScriptParser.cpp
  tools/llvm-rc/ResourceScriptParser.h
  tools/llvm-rc/ResourceScriptToken.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46511.145418.patch
Type: text/x-patch
Size: 4283 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180506/104885d8/attachment.bin>