[PATCH] D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 2 inline comments as done.
sfertile added inline comments.


================
Comment at: ELF/Thunks.cpp:197-203
+// Any call site that needs to call through a plt entry needs a call stub in
+// the .text section. The call stub is responsible for:
+// 1) Saving the toc-pointer to the stack.
+// 2) Loading the target functions address from the procedure linkage table into
+//    r12 for use by the target functions global entry point, and into the count
+//    register.
+// 3) Transfering control to the target function through an indirect branch.
----------------
ruiu wrote:
> Thank you for writing this!
Happy to :)


================
Comment at: ELF/Thunks.cpp:587
+  llvm_unreachable("add Thunk only supported for ARM, Mips and PowerPC");
   return nullptr;
 }
----------------
grimar wrote:
> btw, you do not need to return after `llvm_unreachable`
Thanks, I've updated this in the commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D46204