[PATCH] D46244: [LLD] [COFF] Allow specifying export forwarding in a def file

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Driver.cpp:631
     Export E2;
+    if (E1.ExtName != E1.Name && StringRef(E1.Name).contains('.')) {
+      E2.Name = E1.ExtName;
----------------
mstorsjo wrote:
> ruiu wrote:
> > Can you add a comment?
> Sure - I can add one like this:
> 
> In simple cases, only Name is set. Renamed exports are parsed and set as "ExtName = Name". If Name has the form "OtherDll.Func", it shouldn't be a normal exported function but a forward to another DLL instead.
> 
> 
Sounds good! I'd also mention that this is a MS linker feature.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46244