[PATCH] D46072: [DagCombine][InstCombine][NFC] De Morgan law tests

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 5 09:05:53 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D46072#1089133, @spatel wrote:

> LGTM. I think this covers typical and unusual cases that aren't visible anywhere else, so let's get this committed and off the dependency list.


These tests are only for the base pattern, *if* we want to evaluate the entirety of the problem <https://reviews.llvm.org/D46073#1086745> (moving/fusing `not`), these tests won't be sufficient.
Thus i'm not sure i should land this as-is.


Repository:
  rL LLVM

https://reviews.llvm.org/D46072





More information about the llvm-commits mailing list