[PATCH] D45320: [MemDep] Fixed handling of invariant.group

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 5 07:59:10 PDT 2018


Prazek added a comment.

In https://reviews.llvm.org/D45320#1089119, @dberlin wrote:

> During MemorySSA development, i'm pretty positive we tried some similar types of reverse maps, and while it did relatively okay on "llvm + clang testsuite", it fell down pretty hard in the real world from memory usage.
>
> Adding George to see if he remembers any cases, so you have some stuff to test this all with.
>  He's on vacation, but i believe gets back next week.


I don't think it would be a problem here, I don't expect this map to keep more than couple of entries (for most cases 0 and 1). The same thing goes to the previous approach.


Repository:
  rL LLVM

https://reviews.llvm.org/D45320





More information about the llvm-commits mailing list