[PATCH] D46031: [DAGCombiner] Masked merge: if 'B' is constant, de-canonicalize the pattern (invert the mask).

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 5 04:30:54 PDT 2018


lebedev.ri abandoned this revision.
lebedev.ri added a comment.

In https://reviews.llvm.org/D46031#1088257, @lebedev.ri wrote:

> In https://reviews.llvm.org/D46031#1088250, @spatel wrote:
>
> > I want to look at that x86 timing difference in more detail, but let me ask first: can we split this patch up and look at the changes independently?
> >  I think there are 3 parts:
> >
> > 1. Ignore 'not'.
> > 2. Change x86 hasAndNot().
> > 3. Improve matching for AndNot with constant.
>
>
> Yes, i think i can split it into three, will post tomorrow.


Done, https://reviews.llvm.org/D46492 https://reviews.llvm.org/D46493 https://reviews.llvm.org/D46494.


Repository:
  rL LLVM

https://reviews.llvm.org/D46031





More information about the llvm-commits mailing list