[PATCH] D32673: [CaptureTracking] Handle capturing of launder.invariant.group
Piotr Padlewski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 5 03:29:46 PDT 2018
Prazek added a comment.
In https://reviews.llvm.org/D32673#1087542, @xbolva00 wrote:
> In https://reviews.llvm.org/D32673#1087535, @Prazek wrote:
>
> > Fix test
>
>
> Maybe you could even regenerate test file?
>
> ./update_test_checks.py ~/LLVM/llvm/test/Transforms/FunctionAttrs/nocapture.ll
>
> Strange, If I did it, i got "WARNING: Found conflicting asm under the same prefix: 'CHECK'!" (@spatel, maybe you can look on it why this warning happens?)
After regenerating checks I found out that the autogenerated tests does not actually test what they should. This is because labels does not check function arguments.
This is totally oposite to what this test is doing - it does not modify the actual function IR, but it adds nocapture attributes, so checking function signature is totally sufficient.
Repository:
rL LLVM
https://reviews.llvm.org/D32673
More information about the llvm-commits
mailing list