[PATCH] D46407: [tools] Introduce llvm-strip

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:487-490
+  if (InputArgs.size() == 0 || InputArgs.hasArg(STRIP_help)) {
+    T.PrintHelp(outs(), "llvm-strip <input> [ <output> ]", "strip tool");
+    exit(0);
+  }
----------------
jhenderson wrote:
> alexshap wrote:
> > jhenderson wrote:
> > > I think the norm is to exit(1) if the input count is 0, unless help has been specified.
> > i was looking at the current behavior, would be better to have consistency here, we can update them both, though
> Yes, I think we should update them both. Happy for that to be a separate change though.
ok, sure,
I will send a separate diff to update it once this gets committed.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:498-499
+
+  if (Positional.empty())
+    error("No input file specified");
+
----------------
jhenderson wrote:
> Test case?
yeah, will add


Repository:
  rL LLVM

https://reviews.llvm.org/D46407