[PATCH] D46478: [Coverage] Do not skip functions with the same name when loading CoverageMapping.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 15:57:55 PDT 2018


vsk added a comment.

No concerns from me, as we appear to deduplicate function records at a lower level (in VersionedCovMapReader).

I'll note that we appear to take this early return a few times while running tests: http://lab.llvm.org:8080/coverage/coverage-reports/llvm/coverage/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp.html#L212

I'd be curious to know which tests trigger the path, and whether they are simply too relaxed?


Repository:
  rL LLVM

https://reviews.llvm.org/D46478





More information about the llvm-commits mailing list