[PATCH] D46480: Update ThinLTO Indexing logic

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lld/ELF/LTO.cpp:300
+    if (Config->SaveTemps)
+      saveBuffer(Buff[0], Config->OutputFile + ".lto.o");
+    exit(0);
----------------
There won't always be a regular LTO file created via splitting for ThinLTO builds, so Buff[0] should be empty some of the time. Do you have a test for this case?

The other thing being done by the loop below is a call to createObjectFile, does that need to be done for Buff[0] if non-empty too?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46480