[PATCH] D46457: [asan] Add a magic shadow value for shadw gap

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 15:01:33 PDT 2018


kcc added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_errors.cc:517
   PrintShadowByte(str, "  Right alloca redzone:    ", kAsanAllocaRightMagic);
+  PrintShadowByte(str, "  Shadow memory:           ", kAsanShadowMemory);
 }
----------------
Maybe "Shadow gap" and kAsanShadowGap? 


================
Comment at: compiler-rt/lib/asan/asan_internal.h:150
 const int kAsanAllocaRightMagic = 0xcb;
+const int kAsanShadowMemory = 0xcc;
 
----------------
add a comment why you need it.


Repository:
  rL LLVM

https://reviews.llvm.org/D46457





More information about the llvm-commits mailing list