[PATCH] D46479: [WebAssembly] Only perform sanity checking of relocation targets in debug builds

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 14:52:35 PDT 2018


ruiu added a comment.

LGTM with this chagne.



================
Comment at: wasm/InputChunks.cpp:60
+
+#ifndef NDEBUG
+void InputChunk::verifyRelocTargets() const {
----------------
I think it is better to define this function whether it is debug or not make the number of moving things as small as possible. You can just not call it if not debug.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46479





More information about the llvm-commits mailing list