[PATCH] D46456: [asan] Add support for Myriad RTEMS memory map

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_mapping.h:231
 #define SHADOW_GRANULARITY (1ULL << SHADOW_SCALE)
-#define MEM_TO_SHADOW(mem) (((mem) >> SHADOW_SCALE) + (SHADOW_OFFSET))
+#define MEM_TO_SHADOW(mem) \
+  (((__asan::RawAddr(mem) - kLowMemBeg) >> SHADOW_SCALE) + (SHADOW_OFFSET))
----------------
this section is very hard to read (and, hence, maintain) due to extra ?:
I'd prefer if you create a separate asan_mapping_myriad.h or some such and hide the specific logic there. 


Repository:
  rL LLVM

https://reviews.llvm.org/D46456